Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Categories List: Add spacing support #43647

Merged
merged 1 commit into from
Sep 6, 2022
Merged

Categories List: Add spacing support #43647

merged 1 commit into from
Sep 6, 2022

Conversation

ndiego
Copy link
Member

@ndiego ndiego commented Aug 26, 2022

Related:

What?

Add padding and margin support to the Categories List block.

Why?

To create consistency across blocks.

How?

Added the relevant block supports in block.json

Testing Instructions

  1. Insert a new Categories List block.
  2. Confirm the Dimension control panel allows you to add both padding and margin.
  3. Adding padding and margin.

Screenshots or screencast

categories-spacing

@ndiego ndiego added [Type] Enhancement A suggestion for improvement. [Block] Categories Affects the Categories Block [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi labels Aug 26, 2022
@ndiego ndiego self-assigned this Aug 26, 2022
@ndiego ndiego mentioned this pull request Aug 26, 2022
Open
carolinan
carolinan approved these changes Sep 1, 2022
View reviewed changes
Copy link
Contributor

@carolinan carolinan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

theme.json, global styles and editing individual blocks works well.

aaronrobertshaw
aaronrobertshaw approved these changes Sep 6, 2022
View reviewed changes
Copy link
Contributor

@aaronrobertshaw aaronrobertshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works as advertised for me as well via block editor, Global Styles, and Theme.json. 👍

@aaronrobertshaw aaronrobertshaw merged commit ec29b9c into WordPress:trunk Sep 6, 2022
@github-actions github-actions bot added this to the Gutenberg 14.1 milestone Sep 6, 2022
@femkreations femkreations added the Needs User Documentation Needs new user documentation label Sep 20, 2022
@femkreations femkreations mentioned this pull request Sep 24, 2022
Closed
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaronrobertshaw aaronrobertshaw aaronrobertshaw approved these changes

@carolinan carolinan carolinan approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

@ryanwelcher ryanwelcher Awaiting requested review from ryanwelcher

@juanmaguitar juanmaguitar Awaiting requested review from juanmaguitar juanmaguitar is a code owner

@fabiankaegy fabiankaegy Awaiting requested review from fabiankaegy fabiankaegy is a code owner

@ramonjd ramonjd Awaiting requested review from ramonjd

@tellthemachines tellthemachines Awaiting requested review from tellthemachines

Assignees

@ndiego ndiego

Labels
[Block] Categories Affects the Categories Block [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi Needs User Documentation Needs new user documentation [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
Gutenberg 14.1
Development

Successfully merging this pull request may close these issues.
4 participants
@ndiego @carolinan @aaronrobertshaw @femkreations